Commits counted double

Avatar

Peter D'Hoye

5 months ago

I just noticed that my recent commits are shown twice. Something went wrong?


Avatar

Peter D'Hoye

5 months ago

For example, see here: link


Avatar

Robin Luckey

5 months ago

Hi Peter,

Congratulations! Of all the bug reports we get in the forums, this is the hardest to debug! :-)

Almost certainly, something has gone wrong in our incremental updater, causing it to re-import commits. I was hoping these bugs were gone forever, but I am not so lucky.

We'll probably need to re-download the project from scratch (sigh -- it's a big download), and I'll try to root out the cause of the problem.

Thanks for the report. :-)

Robin


Avatar

Peter D'Hoye

5 months ago

You're welcome ;)


Avatar

LYRIKpage

4 months ago

Bad news. I found double commits in qemu. These must have been there since the initial import as they start with the second commit dated from 2005.


Avatar

LYRIKpage

4 months ago

Depending on the internal structures of your data storage, there might be a way of identifying and removing double commits in all projects without downloading them from scratch. On the other hand, maybe there isn't. Good luck!


Avatar

Robin Luckey

4 months ago

I'm optimistic that whatever bug caused the doubled commits in qemu has already been fixed. We had some trouble with this in the past, so older reports on Ohloh might still have some lingering doubles. I thought we had re-analyzed all of them, but they're a bit hard to track down.

We do have some safeguards in place now to detect doubles, but since it's entirely possible that there really are two consecutive commits with the same comment and files changed (this frequently happens when someone forgets a minor fix or unwinds a change), we can't be draconian about it.

I'll run a reimport of qemu, which should clear up the duplicates. If we get duplicates on new commits, that's scary.

Thanks, Robin


Avatar

Peter D'Hoye

4 months ago

The latest update for Rockbox looks OK for the recent commits, in the older ones I still see doubles...


Avatar

Robin Luckey

4 months ago

Hi Peter,

I've been trying various things to try to restore the report to a correct state.

First, I tried a complete new download of the project. Quite mysteriously, the result was an empty report with 0 commits and 0 lines of code. I felt that this was incorrect :-).

So while I investigate the reason for this, I tried simply re-analyzing our previous download. The commits are still doubled, so it looks like the problem will indeed require a full download to fix. I'll give it another go.


Avatar

LYRIKpage

4 months ago

If you did re-import qemu, I'm sorry to say that it didn't help. The commits from 5 years ago are still shown twice.


Avatar

Robin Luckey

4 months ago

The re-download is still ongoing. It's probably going to take a few more days.


Avatar

Peter D'Hoye

4 months ago

AFAICS, RockBox is fine now.

Thanks for fixing it!