Ohloh by Black Duck

 Follow @ Meta   Join Now

 Settings |  Report Duplicate
Very High Activity
279

Commits : Individual Commit

  Analyzed 9 days ago based on code collected 10 days ago.

Commit ID

Avatar Contributor: commit-queue
as commit...@webkit.org		 Files Modified: 16
Date: 10-April-2012 at 19:15 Lines Added: 201
Repository: http://svn.webkit.org/repository/webkit/trunk /trunk Lines Removed: 59
Commit Comment: msqrt's implied mrow should do operator stretching https://bugs.webkit.org/show_bug.cgi?id=82353
Patch by David Barton <dbar...@mathscribe.com> on 2012-04-10
Reviewed by Julien Chaffraix.

Source/WebCore:

An <msqrt> with more than one child is supposed to surround them with an implied <mrow>.
This patch does this, and thus includes vertical operator stretching. We also fix some
problems with the old RenderMathMLSquareRoot.cpp: possibly shared RenderStyles were
being modified, and layout() was using heights of children without checking whether they
needed layout themselves first.

To leave room for the radical sign, we use intrinsic padding. This is simpler and more
efficient than using anonymous RenderStyles.

Added tests to mo-stretch.html and style.xhtml. Regression tests are in roots.xhtml.

* css/mathml.css:
(msqrt):
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::paddingTop):
(WebCore::RenderMathMLBlock::paddingBottom):
(WebCore::RenderMathMLBlock::paddingLeft):
(WebCore::RenderMathMLBlock::paddingRight):
(WebCore::RenderMathMLBlock::paddingBefore):
(WebCore::RenderMathMLBlock::paddingAfter):
(WebCore::RenderMathMLBlock::paddingStart):
(WebCore::RenderMathMLBlock::paddingEnd):
* rendering/mathml/RenderMathMLBlock.h:
(RenderMathMLBlock):
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::RenderMathMLRow):
(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):
* rendering/mathml/RenderMathMLRow.h:
(RenderMathMLRow):
* rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore):
(WebCore::RenderMathMLSquareRoot::addChild):
(WebCore::RenderMathMLSquareRoot::computePreferredLogicalWidths):
(WebCore::RenderMathMLSquareRoot::computeLogicalHeight):
(WebCore::RenderMathMLSquareRoot::layout):
(WebCore::RenderMathMLSquareRoot::paint):
* rendering/mathml/RenderMathMLSquareRoot.h:
(RenderMathMLSquareRoot):

LayoutTests:

* mathml/presentation/mo-stretch.html:
* mathml/presentation/style.xhtml:
* platform/mac/mathml/presentation/attributes-expected.txt:
* platform/mac/mathml/presentation/mo-stretch-expected.png:
* platform/mac/mathml/presentation/mo-stretch-expected.txt:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/style-expected.png:
* platform/mac/mathml/presentation/style-expected.txt:
 

Changes by Language

Language Code Added Code Removed Comments Added Comment Removed Blanks Added Blanks Removed
  C++ 161 48 8 9 21 0
  HTML 9 0 0 0 1 0
  CSS 1 2 0 0 0 0

Changes by File

Showing page 1 of 2
File Language Code Added Code Removed Comments Added Comment Removed Blanks Added Blanks Removed
LayoutTests/ChangeLog   No source code was detected in this file.
...ests/mathml/presentation/mo-stretch.html HTML 9 0 0 0 1 0
LayoutTests/mathml/presentation/style.xhtml   No source code was detected in this file.
...hml/presentation/attributes-expected.txt   No source code was detected in this file.
...hml/presentation/mo-stretch-expected.txt   No source code was detected in this file.
...c/mathml/presentation/roots-expected.txt   No source code was detected in this file.
...c/mathml/presentation/style-expected.txt   No source code was detected in this file.
Source/WebCore/ChangeLog   No source code was detected in this file.
Source/WebCore/css/mathml.css CSS 1 2 0 0 0 0
...e/rendering/mathml/RenderMathMLBlock.cpp C++ 92 4 0 0 9 0
 
 
 

Project Summary

Code Data

SCM Data

Community Data

 

Creative Commons License Copyright © 2013 Black Duck Software, Inc. and its contributors, Some Rights Reserved. Unless otherwise marked, this work is licensed under a Creative Commons Attribution 3.0 Unported License . Ohloh ® and the Ohloh logo are trademarks of Black Duck Software, Inc. in the United States and/or other jurisdictions. All other trademarks are the property of their respective holders.