|Date:||16-May-2012 at 18:18||Lines Added:||41|
|Repository:||http://svn.webkit.org/repository/webkit/trunk /trunk||Lines Removed:||0|
|Commit Comment:||Crash due to first-letter not getting computed on RenderTableCell https://bugs.webkit.org/show_bug.cgi?id=86133
Reviewed by Abhishek Arya.
RenderTableCell overrides RenderBlock::layout() but doesn't call
updateFirstLetter() in it. This is normally not a problem because
updateFirstLetter() gets called during preferred logical width
computation, but there exist rare occasions when layout of the table
cell happens without preferred logical widths being dirty, in which
case the first-letter update can be skipped.
This patch adds a call to updateFirstLetter() to
RenderTableCell::layout(). This ensures that the first-letter is up
to date before commencing block layout.
Test to exercise crashing condition in bug 86133.
* fast/css-generated-content/first-letter-table-cell-format-block-crash-expected.txt: Added
* fast/css-generated-content/first-letter-table-cell-format-block-crash.html: Added
|File||Language||Code Added||Code Removed||Comments Added||Comment Removed||Blanks Added||Blanks Removed|
|LayoutTests/ChangeLog||No source code was detected in this file.|
|...ble-cell-format-block-crash-expected.txt||No source code was detected in this file.|
|Source/WebCore/ChangeLog||No source code was detected in this file.|
Copyright © 2013 Black Duck Software, Inc. and its contributors, Some Rights Reserved. Unless otherwise marked, this work is licensed under a Creative Commons Attribution 3.0 Unported License . Ohloh ® and the Ohloh logo are trademarks of Black Duck Software, Inc. in the United States and/or other jurisdictions. All other trademarks are the property of their respective holders.