Ohloh by Black Duck

 Follow @ Meta   Join Now

 Settings |  Report Duplicate
Activity Not Available
5

Commits : Individual Commit

  Analyzed about 1 year ago based on code collected about 1 year ago.

Commit ID

Avatar Contributor: Tryskell Files Modified: 28
Date: 26-February-2012 at 22:20 Lines Added: 531
Repository: http://xp-dev.com/svn/acis_project/trunk /trunk Lines Removed: 563
Commit Comment: Olympiads && Heroes, misc
Olympiads && Heroes
- partial addition of L2J fix 5188. Ty Zoey76. Read it on L2J timeline for more infos.
- split one check in 2 for checkNoble( method, and retail systemMessages for both of them.
- you can't see inactive heroes anymore on Monument of Heroes.
- You can't activate hero state if you're on a subclass or are less than level 76 on you main class.
- following values have been modified to fit with IL - using PMFun infos - (the previous refactor has been made from C4 infos) :
- length of a match : 3min to 6min.
- divider for non classed matches : 3 to 5.
- number of needed matches to pretend to Hero status : 5 to 9.
- waiting time before Stadium teleport : 30sec to 120sec.
- preparation time : 45sec to 60sec.
- Buff section is now handled 20secs before match beginning.
- A second full heal is applied during buff section (the first occurs at teleport).
- Shops, as sit state, are broken when you teleport IN and OUT of an stadium. Addition of forceStandUp() method on L2PcInstance for easier use.
- Buffs are cleaned up only at teleport OUT, not directly after the victory/defeat/tie of the match.

Misc
- AdminMovieMaker : IOOB exception catched (ty SweeTs report), 2 typos fixed in commands (bro'a'dcast, not brodcast), don't create intermediate variables "val" && "id".
- Cleanup of L2AttackableAI/L2NpcTemplate : drop of useless code, add of public getters, use of !isEmpty() instead of != null. Should drop the NPE when a mob tries to use a skill.
- revert magic fail formula (custom L2JFree => L2J). I kept the accuracy at 2 decimals.
- break enchant process and send systemMessage BUT CONTINUE the action in following conditions :
- you give / take an item from your pet.
- you give / take an item from warehouse.
- you are pressing any type of bypass link from a warehouse NPC type (castle / normal).
- can't interact anymore with any NPC if you're on transaction process.
- if you're actually in transaction process, break following actions :
- you give / take an item from your pet.
- you give / take an item from warehouse.
- fix Chant of Victory issue with rCrit (basemul != mul).

Report any issue on Olympiads, and CLEAN CORRECTED ISSUES in the dedicated thread, ty in advance.
 

Changes by Language

Language Code Added Code Removed Comments Added Comment Removed Blanks Added Blanks Removed
  Java 402 514 52 26 72 18
  XML 3 3 0 0 0 0
  HTML 2 2 0 0 0 0

Changes by File

Showing page 1 of 3
File Language Code Added Code Removed Comments Added Comment Removed Blanks Added Blanks Removed
.../data/html/admin/movie/main_notempty.htm HTML 2 2 0 0 0 0
...apack/data/xml/admin_commands_rights.xml XML 2 2 0 0 0 0
aCis_datapack/data/xml/skills/1300-1399.xml XML 1 1 0 0 0 0
aCis_gameserver/config/events.properties   No source code was detected in this file.
...sf/l2j/gameserver/ai/L2AttackableAI.java Java 123 256 19 19 47 0
...dmincommandhandlers/AdminMovieMaker.java Java 17 16 0 0 0 0
.../instance/L2CastleWarehouseInstance.java Java 9 4 0 0 1 0
.../instance/L2OlympiadManagerInstance.java Java 7 0 0 0 1 0
...r/model/actor/instance/L2PcInstance.java Java 12 1 7 2 3 0
.../actor/instance/L2WarehouseInstance.java Java 9 3 0 1 1 0
 
 
 

Project Summary

Code Data

SCM Data

Community Data

 

Creative Commons License Copyright © 2013 Black Duck Software, Inc. and its contributors, Some Rights Reserved. Unless otherwise marked, this work is licensed under a Creative Commons Attribution 3.0 Unported License . Ohloh ® and the Ohloh logo are trademarks of Black Duck Software, Inc. in the United States and/or other jurisdictions. All other trademarks are the property of their respective holders.