Commits : Individual Commit

  Analyzed 3 days ago based on code collected 3 days ago.

Commit ID f96eb02a55c0a6ae2fdcae16ce1542fd5801741b

Anon80 Contributor: fisc...@chromium.org Files Modified: 8
Date: 05-July-2012 at 20:32 Lines Added: 601
Repository: http://git.chromium.org/git/chromium.git trunk Lines Removed: 520
Commit Comment: Make VideoDecodeAcceleratorTest work for VAVDA and fixed a bunch of bugs the test found - The bulk of the CL turns RenderingHelperEGL into RenderingHelperGL (by making it EGL-vs-GLX-agnostic) - VaapiH264Decoder::AssignPictureBuffer: it's fine to restart decode after a Reset(), so allow that. - VaapiH264Decoder::FillVARefFramesFromDPB: faster/clearer error condition, and small cleanup. - VaapiH264Decoder::Flush: emit the final in-progress picture. - VaapiH264Decoder::DecodeOneFrame: insist on having at least two output surfaces before attempting a decode to avoid running out. - VaapiVideoDecodeAccelerator::client_ is now a WeakPtr instead of a raw pointer, to do correct lifetime accounting. This also allows dropping the helper methods on VAVDA whose only purpose was to triple-check client_'s presence before dispatching calls on it. - VaapiVideoDecodeAccelerator::InitialDecodeTask: account for the possibility of multiple in-flight Decode()s, and remove unnecessary task-posting.
Two remaining issues are:
- the test-25fps.h264 testdata file triggers bug#135548
- the pure-decode performance (at least in Debug) of VAVDA is not as good as the reference that vdatest was originally built for, so some tests "fail" on lower-than-expected fps rates. This probably just needs to be a per-platform expectation.

TBR=bre...@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10701071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145556 0039d316-1c4b-4281-b951-d872f2087c98
 

Changes by Language

Language Code Added Code Removed Comments Added Comment Removed Blanks Added Blanks Removed
  C++ 515 432 38 33 48 55

Changes by File

Showing page 1 of 1
File Language Code Added Code Removed Comments Added Comment Removed Blanks Added Blanks Removed
...common/gpu/media/rendering_helper_egl.cc C++ 0 325 0 18 0 48
.../common/gpu/media/rendering_helper_gl.cc C++ 385 0 17 0 43 0
...t/common/gpu/media/vaapi_h264_decoder.cc C++ 11 6 1 1 2 0
.../media/vaapi_video_decode_accelerator.cc C++ 43 51 4 0 0 4
...u/media/vaapi_video_decode_accelerator.h C++ 6 5 1 7 0 3
...dia/video_decode_accelerator_unittest.cc C++ 70 45 15 7 3 0
content/content_common.gypi   No source code was detected in this file.
content/content_tests.gypi   No source code was detected in this file.