Login Required. Sign up now -- its free!
Commit Details
Repository
svn://svn.open-ils.org/OpenSRF/trunk
/trunk
by
scottmk
on
2009-11-09 02:47
(22 days ago)
Miscellaneous minor tweaks:
1. Moved nested #includes out of the header file and into the
implementation files as needed.
2. Additions and refinements to comments; adjustments to white space.
3. Changed several functions to return void instead of int, since we don't
look at the return values anyway.
4. Added the const qualifier to several function parameters.
5. In osrfRouterHandleAppRequest(): initialize arr[], an array of pointers,
by setting each pointer to NULL. We had been using memset() on the lot,
relying on a the non-portable assumption that a NULL pointer is
represented by all-bits-zero.
6. Minor rearrangements of the logic here and there, mostly to free things
as soon as we're done with them instead of waiting until the end of the block,
or to defer the declarations of things until we're about to use them.
7. Replaced a couple of calls to jsonObjectToSimpleString() with calls to
jsonObjectGetString(), in order to eliminate a malloc() and a free().
8. Renamed osrfRouterHandleAppResponse() to osrfRouterSendAppResponse(),
which is more descriptive and less vague.
M src/router/osrf_router.h
M src/router/osrf_router.c
M src/router/osrf_router_main.c
Language Totals
| Language | Code Added | Code Removed | Comments Added | Comments Removed | Blanks Added | Blanks Removed | |
|---|---|---|---|---|---|---|---|
| C | 109 | 105 | 156 | 82 | 2 | 19 |