High Activity

Commits : Individual Commit

  Analyzed 5 days ago based on code collected 5 days ago.

Commit ID 7e25234d6f25cf1dd622e4d17e70902c99e63b8b

Avatar Contributor: phk
as Poul-Henning Kamp
Files Modified: 6
Date: 27-June-2012 at 09:51 Lines Added: 98
Repository: git://git.varnish-cache.org/varnish-cache master Lines Removed: 152
Commit Comment: Overhaul the thread-pool herding code.
NB: Changes to parameter defaults & units included in this commit!

I tried to apply some queuing theory to this problem and as much as
I admire Agner Krarup Erlang, his math isn't much help when you don't
know any of the relevant metrics for your queue.

Instead I took a much simpler approach: "If we fail to get a thread,
we probably need more threads", and have rewritten the herder to to
react faster and more reliably to such events.

I went over the parameters for thread-pools and normalized timeouts
to seconds rather than milliseconds (beware!) and polished descriptions
etc.
 

Changes by Language

Language Code Added Code Removed Comments Added Comment Removed Blanks Added Blanks Removed
  C 95 130 3 15 0 7

Changes by File

Showing page 1 of 1
File Language Code Added Code Removed Comments Added Comment Removed Blanks Added Blanks Removed
bin/varnishd/cache/cache_pool.c C 40 76 3 15 0 6
bin/varnishd/common/params.h C 6 6 0 0 0 1
bin/varnishd/mgt/mgt_param.c C 2 2 0 0 0 0
bin/varnishd/mgt/mgt_param.h C 1 1 0 0 0 0
bin/varnishd/mgt/mgt_pool.c C 46 45 0 0 0 0
bin/varnishtest/tests/c00002.vtc   No source code was detected in this file.
 
 
 

Creative Commons License Copyright © 2013 Black Duck Software, Inc. and its contributors, Some Rights Reserved. Unless otherwise marked, this work is licensed under a Creative Commons Attribution 3.0 Unported License . Ohloh ® and the Ohloh logo are trademarks of Black Duck Software, Inc. in the United States and/or other jurisdictions. All other trademarks are the property of their respective holders.