Ohloh by Black Duck

 Follow @ Meta   Join Now

 Settings |  Report Duplicate
Very High Activity
102

Commits : Individual Commit

  Analyzed about 13 hours ago based on code collected about 14 hours ago.

Commit ID 31d16faf46e09327ba17651ece6499ec7d963b5a

Anon80 Contributor: davilla Files Modified: 14
Date: 31-March-2012 at 17:49 Lines Added: 1066
Repository: git://github.com/xbmc/xbmc.git master Lines Removed: 702
Commit Comment: refactor visualizations for gles. 1) never use gloabls from xbmc core, you will die. 2) never use same class names as xbmc core, you will die. 3) never include anything from xbmc core except xbmc_vis_dll.h, you will die. 4) never use -undefined dynamic_lookup (darwin) or -Wl,--unresolved-symbols=ignore-all (linux) when linking, these will hide violations with 1) and 3) and you will die. 5) addons for visualizations needs two enhancements. a) add an addons visualizations context that is created by addon and retained by xbmc core, deleted by addon on destroy. This context is passed on calls into addon. This eliminates the need for local gloabls as now the addon has a context for storage. b) addons needs a callback for logging so we never include log.h which volates 3).
 

Changes by Language

Language Code Added Code Removed Comments Added Comment Removed Blanks Added Blanks Removed
  C++ 739 458 190 141 125 95
  Make 12 8 0 0 0 0

Changes by File

Showing page 1 of 2
File Language Code Added Code Removed Comments Added Comment Removed Blanks Added Blanks Removed
.../visualizations/EGLHelpers/GUIShader.cpp C++ 0 43 0 27 0 12
xbmc/visualizations/EGLHelpers/GUIShader.h C++ 0 31 0 20 0 10
xbmc/visualizations/EGLHelpers/Shader.cpp C++ 0 196 0 42 0 30
xbmc/visualizations/EGLHelpers/Shader.h C++ 0 124 0 50 0 40
...sualizations/EGLHelpers/VisGUIShader.cpp C++ 39 0 27 0 9 0
...visualizations/EGLHelpers/VisGUIShader.h C++ 26 0 20 0 6 0
...ualizations/EGLHelpers/VisMatrixGLES.cpp C++ 299 0 30 0 41 0
...isualizations/EGLHelpers/VisMatrixGLES.h C++ 51 0 20 0 10 0
.../visualizations/EGLHelpers/VisShader.cpp C++ 154 0 42 0 26 0
xbmc/visualizations/EGLHelpers/VisShader.h C++ 116 0 50 0 33 0
 
 
 

Project Summary

Code Data

SCM Data

Community Data

 

Creative Commons License Copyright © 2013 Black Duck Software, Inc. and its contributors, Some Rights Reserved. Unless otherwise marked, this work is licensed under a Creative Commons Attribution 3.0 Unported License . Ohloh ® and the Ohloh logo are trademarks of Black Duck Software, Inc. in the United States and/or other jurisdictions. All other trademarks are the property of their respective holders.